Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix support for Bundler restarts #2576

Merged
merged 1 commit into from
Jan 6, 2025
Merged

Fix support for Bundler restarts #2576

merged 1 commit into from
Jan 6, 2025

Conversation

CamJN
Copy link
Member

@CamJN CamJN commented Dec 2, 2024 •
edited by FooBarWidget
Loading

By using Process.setproctitle instead of renaming $0.

See original problem description.

@CamJN CamJN self-assigned this Dec 2, 2024
@CamJN CamJN added this to the 6.0.24 milestone Dec 2, 2024
This was linked to issues Dec 2, 2024
Passenger will not preload rack app after Bundler 2.5.11, if correct bundler is not installed #2567
Closed
Passenger AppPreloader reports existing ruby executables as non existing when BUNDLED WITH in Gemfile.lock differs from pre-installed #2577
Closed
@CamJN CamJN requested a review from FooBarWidget December 6, 2024 20:05
@CamJN CamJN force-pushed the bugfix/bundler_problem branch from 6da2e99 to a2750ca Compare December 6, 2024 20:36
@FooBarWidget
Copy link
Member

This is a good workaround for #2577 in order to make the error more legible, but it's ultimately not a fix. bundle exec on the CLI works, as does the 'direct' spawn method, so we need to figure out what's really going on here.

@FooBarWidget
Copy link
Member

@CamJN I have analyzed the root cause and identified a better fix strategy. Please see:
#2577 (comment)
#2577 (comment)

@CamJN CamJN modified the milestones: 6.0.24, 6.0.25 Dec 9, 2024
@CamJN CamJN force-pushed the bugfix/bundler_problem branch 2 times, most recently from f2bcc97 to 26bf079 Compare December 12, 2024 22:48
@CamJN CamJN force-pushed the bugfix/bundler_problem branch from 26bf079 to 2dcd8f0 Compare December 19, 2024 20:13
@CamJN
Copy link
Member Author

CamJN commented Dec 19, 2024

We can just do what puma does, and use Process.setproctitle, then it doesn't matter what bundler decides to do, or what version users are running. Works back to ~ Ruby 2.1.

@CamJN CamJN force-pushed the bugfix/bundler_problem branch from 2dcd8f0 to 0c34cd1 Compare January 3, 2025 20:20
@CamJN CamJN force-pushed the bugfix/bundler_problem branch from 0c34cd1 to 2f6e5e8 Compare January 3, 2025 20:32
@FooBarWidget FooBarWidget changed the title Bugfix/bundler problem Fix support for Bundler restarts Jan 6, 2025
@FooBarWidget FooBarWidget merged commit 4315886 into stable-6.0 Jan 6, 2025
32 of 38 checks passed
@FooBarWidget FooBarWidget deleted the bugfix/bundler_problem branch January 6, 2025 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FooBarWidget FooBarWidget FooBarWidget approved these changes

Assignees

@CamJN CamJN

Labels
None yet
Projects
None yet
Milestone
6.0.25
2 participants
@CamJN @FooBarWidget