added GrcpGatewayLogger that implements grpc-middleware #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ogimenezb
changed the title
|
Once you have revised it and committed can you please tag it so I can make pull request to grpc-ecosystem |
Sure |
|
Ready to make pull request to grpc-ecosystem, let me know once you create a new tag so I can make a clean request with a correct go.mod |
|
sorry for busy state today, I will tag it ASAP |
|
no problem, we all have busy days, take your time. |
|
I tagged v1.0.72, thanks for your help and patient. |
|
Thanks!!! |
|
I has been merged as a new log provider go-grpc-middleware for v2. |
|
oh, many thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Example included in readme.
It should be good to go.