Ready for engineers to add reference docs #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@odyslam any idea why tests would be failing? (were they always? didn't look like there's anything when I tried to rebase) |
odyslam
reviewed
Jul 5, 2024
docs/introduction.mdx
Outdated
| @@ -0,0 +1,36 @@ | |||
| --- | |||
| title: Introduction to Phylax STL | |||
There was a problem hiding this comment.
The name of the library is phylax-std
odyslam
requested changes
Jul 5, 2024
|
ah my fingers must have done that because of C++ STL
can I change the menu item to say “Phylax Standard Library” like
foundry-rs/forge-std does? (STD means “sexually transmitted disease” in
english so it feels odd for a header)
…On Fri, Jul 5, 2024 at 10:41 AM odysseas.eth ***@***.***> wrote:
***@***.**** requested changes on this pull request.
fix the name of the library
—
Reply to this email directly, view it on GitHub
<#20 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABFARBJPNALJQMDOBNUWY3ZK3LEDAVCNFSM6AAAAABKIRJO22VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDCNRRGA3TGNRTGI>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Deploying phylax-std with
|
| Latest commit: |
277421b
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://917f747c.phylax-std.pages.dev |
| Branch Preview URL: | https://jon-docs-setup.phylax-std.pages.dev |
|
@odyslam updated to Phylax Standard Library, how's that? (this is just a placeholder btw, so that engineers have an example of how pages work) |
|
I think we can close this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now whenever the docs github action runs, it'll pull down docs from this repo and into the sidebar section on the lower left of this screenshot (the "Phylax Standard Library" label and everything under it is defined in this repo and dropped in to the site)
There's a group for reference docs, with a sample page people can copy if they like. There's also an introduction page with some pointers, as an example of top-level pages you can add