Make rapidjson dependency managed at cmake configure step #13
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rapidjson
is probably the least common dependency of EPIK.While a reasonable version of boost will be present on most servers, this library will not.
This PR makes the dependency managed at configure time by cmake.
It just clones a fixed version from its repository and link the headers.
For me, this approach worked well on 2 different INRAE servers. The library was absent from the system and adding it via some environment would have been time-consuming (no root access).
Changes:
epik/rapidjson.cmake
manages the cloning at configure step.set(RAPIDJSON_INCLUDE_DIRS ${source_dir}/include)
makes sure it will be accessible byepik/CMakeLists.txt
I'm just not sure why you used 2 variables on the following lines of this last file, but it did not interfere in my case: