Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make selected UI elements more visible #12

Open
gaurav opened this issue Mar 27, 2018 · 9 comments
Open

Make selected UI elements more visible #12

gaurav opened this issue Mar 27, 2018 · 9 comments
Labels
difficulty: moderate Should take 3-5 days to close user interface Issues involving the user interface. Suggests that further iteration might be necessary.
Milestone

Comments

@gaurav
Copy link
Member

gaurav commented Mar 27, 2018

Selected phyloreferences are not highlighted brightly enough -- make them really intensely coloured, and consider scrolling to them when they are selected. Remember that changing from black to any other colour reduces the constrast between them, so think about highlighting their background as well.

The idea here seems to be that my eye/screen setup is better than most, so I should make it really obvious and garish on my screen, and then it'll be visible for them.

@gaurav gaurav changed the title Make selected phyloreferences brighter Make selected UI elements more visible Mar 27, 2018
@gaurav
Copy link
Member Author

gaurav commented Apr 10, 2018

In 33dbd8f, I've moved the node descriptions into CSS so it's easier to edit them. Currently, I'm trying:

  • Nodes: 10pt
  • Internal specifier node: 12pt green bolder
  • External specifier node: 12pt magenta bolder
  • Terminal nodes without taxonomic units: turkey red italic bolder
  • Internal label: 12pt serif italic
  • Selected internal label: 16pt blue

@gaurav
Copy link
Member Author

gaurav commented Apr 24, 2018

I've found a new way of testing this: Ctrl+Win+C on Windows 10 turns Windows into black and white mode, which is a neat way of making sure your formatting is clear enough without any colours at all.

gaurav added a commit that referenced this issue May 2, 2018
Changes that improve the user interface and fix minor UI bugs in order to facilitate curation, including:
- Added buttons for deleting phylogenies and phyloreferences.
- Added error reporting when a PHYX file could not be parsed.
- Made phylogeny descriptions editable.
- Added a warning on 'beforeunload' to warn users before closing the app without looking at the JSON output.
- Moved Phylotree.js node descriptions to CSS so that it's easier to modify (#12).
- Moved list of examples into curation-tool.js so it can be expanded easily.
- Downloaded Phylotree.js Javascript and CSS file so that we can use development versions of this program.
- Added "previous phyloreference" and "next phyloreference" button, closes #50.
@gaurav
Copy link
Member Author

gaurav commented May 15, 2018

Increasing the font size and changing the font colour don't seem to have helped very much. I'll try adding a coloured (light-grey) rectangle behind the text as a highlight, as in https://stackoverflow.com/a/16873128/27310

@gaurav
Copy link
Member Author

gaurav commented Jul 20, 2018

Yesterday, @ncellinese and I discussed how to improve the visualization of selected phyloreferences, and we came up with the following plan:

  1. Don't highlight terminals with parsing errors, which are currently displayed in red. This might be better as an optional mode that is useful when reading phylogenies (i.e. it might be better as part of Improve malformed Newick errors and detection #41).
  2. Included terminals and edges should be bolded and coloured in a particular colour, e.g. blue.
  3. Internal specifiers should be coloured green.
  4. External specifiers should be coloured in another colour (orange?).
  5. Rather than trying to write the name of the phyloreference on the phylogeny itself, we should add a symbol to the pinning node (like a pin or a flag) and then add the name of the clade to the legend.
  6. We probably don't need to display all the clades on a phylogeny -- we should probably only show the selected phyloreference by default, but with an option to toggle on and off all the other clade names.
  7. There should be a legend showing what each of these colours mean.

Since these all have the overall goal of improving the display of making selected UI more visible, I'll add it to this issue. However, I anticipate that some of these items will be separated into new issues once I have a better grasp on what works, what is possible with Phylotree.js, and what we need. Here's a rough sketch of how we imagined this would look:

Rough sketch of selected phyloref UI

gaurav added a commit that referenced this issue Jan 29, 2019
Changes that improve the user interface and fix minor UI bugs in order to facilitate curation, including:
- Added buttons for deleting phylogenies and phyloreferences.
- Added error reporting when a PHYX file could not be parsed.
- Made phylogeny descriptions editable.
- Added a warning on 'beforeunload' to warn users before closing the app without looking at the JSON output.
- Moved Phylotree.js node descriptions to CSS so that it's easier to modify (#12).
- Moved list of examples into curation-tool.js so it can be expanded easily.
- Downloaded Phylotree.js Javascript and CSS file so that we can use development versions of this program.
- Added "previous phyloreference" and "next phyloreference" button, closes #50.
@gaurav gaurav added user interface Issues involving the user interface. Suggests that further iteration might be necessary. difficulty: moderate Should take 3-5 days to close labels Aug 9, 2019
@gaurav gaurav added this to the User interface improvements milestone Nov 14, 2019
@gaurav
Copy link
Member Author

gaurav commented Nov 18, 2021

  • When a clade resolves to a terminal node, we should make the font size larger (the same size as the clade label in the tree) so as to make it clear that this node was resolved as the entire clade.

@gaurav gaurav added difficulty: easy Should be easy to do (1-2 days) and removed difficulty: moderate Should take 3-5 days to close labels Dec 15, 2021
@gaurav
Copy link
Member Author

gaurav commented Mar 30, 2022

  • Add a circle at the leaf node to make it clear that it is a clade.
  • Add a legend (blue = specifier, black = resolved clade)
  • "Actual resolved node" should include the label after the text (e.g. 'node24 (labeled as Crocodilus)')
  • Use another color for clade (maybe purple or green), since blue is already used for specifiers -- we can also make leaf node clades into the same color to make the distinction clear

@gaurav gaurav added difficulty: moderate Should take 3-5 days to close and removed difficulty: easy Should be easy to do (1-2 days) labels Oct 4, 2022
@gaurav
Copy link
Member Author

gaurav commented Feb 28, 2024

  • Orange (external terminals) and deep blue (internal terminals)
  • If a terminal node is the pinning node, it should be deep blue (to indicate an internal terminal) and then we use the circle to indicate that the clade is present here. It should also be large and in bold as it currently is. It should be in italics like other clade names.

@gaurav
Copy link
Member Author

gaurav commented Feb 28, 2024

  • If it's a terminal node, we should use the phyloreference name rather than the terminal name (and them maybe add the terminal name afterwards). e.g. [em][strong][font 16]Caimaninae[/font][/strong][/em] [font 14](Caiman crocodylus)[/font 14]

@gaurav
Copy link
Member Author

gaurav commented Feb 28, 2024

  • Don't need a legend: it is somewhat clear from the context why certain things are highlighted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty: moderate Should take 3-5 days to close user interface Issues involving the user interface. Suggests that further iteration might be necessary.
Projects
None yet
Development

No branches or pull requests

1 participant