Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow curators to annotate specifiers as unmatchable #49

Open
gaurav opened this issue Apr 17, 2018 · 0 comments
Open

Allow curators to annotate specifiers as unmatchable #49

gaurav opened this issue Apr 17, 2018 · 0 comments
Labels
enhancement
Milestone
Enhancements not ...

Comments

@gaurav
Copy link
Member

gaurav commented Apr 17, 2018

I've created a simple system to do this as part of #34 in f0cb87d and dd8f816, but its UI needs to be improved. I think we want a four-way system:

  • Specifier could be matched:
    • Specifier reason provided: red 'X'
    • Specifier reason not provided: green check mark
  • Specifier could not be matched:
    • Specifier reason provided: green 'X'
    • Specifier reason not provided: orange asterisk
@gaurav gaurav mentioned this issue Apr 17, 2018
Merged
gaurav added a commit that referenced this issue Apr 17, 2018
@gaurav
Merged simple system for marking specifiers that do not match (#49)
09361a3
gaurav added a commit that referenced this issue Apr 17, 2018
@gaurav
Added simple interface to mark specifiers that couldn't be matched (#49)
7d05dd3
gaurav added a commit that referenced this issue May 8, 2018
@gaurav
Merge pull request #34 from phyloref/improved_curation
fd7d39b 
This pull request changes some aspects of the PHYX model in order to facilitate curation and to keep the Curation Tool in sync with the Curation Workflow. These changes includes:
- Removed `@id` field (closes #2).
- Added a verbatim specifier field for all specifiers (closes #17).
- Added a curator comments field for all phyloreferences (closes #24).
- Allows the curator to document that they expect a single node to resolve to multiple phyloreferences by selecting a matching labeled node from the phyloreferencing panel (#32).
- Added a simple system for marking specifiers that could not be matched (#49).
- Improved display of scientific names and specimens as specifiers.
gaurav added a commit that referenced this issue Jan 29, 2019
@gaurav
Added simple interface to mark specifiers that couldn't be matched (#49)
1bec031
gaurav added a commit that referenced this issue Jan 29, 2019
@gaurav
Merge pull request #34 from phyloref/improved_curation
bb0fb93 
This pull request changes some aspects of the PHYX model in order to facilitate curation and to keep the Curation Tool in sync with the Curation Workflow. These changes includes:
- Removed `@id` field (closes #2).
- Added a verbatim specifier field for all specifiers (closes #17).
- Added a curator comments field for all phyloreferences (closes #24).
- Allows the curator to document that they expect a single node to resolve to multiple phyloreferences by selecting a matching labeled node from the phyloreferencing panel (#32).
- Added a simple system for marking specifiers that could not be matched (#49).
- Improved display of scientific names and specimens as specifiers.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
Enhancements not needed for v1.0
Development

No branches or pull requests
1 participant
@gaurav