Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display multiple phylogenies #315

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from
Draft

Conversation

gaurav
Copy link
Member

@gaurav gaurav commented Jan 16, 2024

This PR is a place for working on displaying multiple phyloreferences on a single phylogeny. It also implements some changes to how we display phyloreferences that resolve to a tip.

This works in both the display:

Screenshot 2024-05-08 at 2 28 02 AM

As well as the Nexus file, as displayed in FigTree:

Screenshot 2024-05-08 at 2 30 14 AM Screenshot 2024-05-08 at 2 30 26 AM

But there are a few issues:

  • Neither FigTree nor our display clearly indicates that two phyloreferences have resolved to the same node (both Crocodylidae and Crocodyloidae resolve to the Crocodylidae node on the phylogeny). We should modify the Nexus export to ensure that we support this fully.
  • We currently draw a small circle on the Crocodylinae node because we put circles on all the nodes (as is the default for Phylotree.js) -- could that be confusing?

@gaurav gaurav force-pushed the display-multiple-phylogenies branch from f685e55 to 374c865 Compare January 17, 2024 06:49
@gaurav gaurav changed the base branch from master to download-phylogeny-as-newick January 17, 2024 06:49
This allows us to support multiple phylorefs.
@gaurav
Copy link
Member Author

gaurav commented Jan 17, 2024

Base automatically changed from download-phylogeny-as-newick to master April 10, 2024 04:16
@gaurav
Copy link
Member Author

gaurav commented May 8, 2024

  • Nothing wrong or misrepresented, but it can be misconstrued that this clade is only one node -- when really there is a whole clade back there.
  • For branch-based, we do want to highlight the entire branch up to the previous node. (This would be nice, but not a priority)
  • For node-based, we don't want to do this.
  • Reserve italics for either phyloreferences or internal labels without clade names.
  • Change the internal node labels so they're in the same font as the terminal labels -- this will indicate that they come from the same place.
  • For the individual phyloreference, don't display the internal label, but rather the phyloreference. Displaying the internal node labels for the summary makes more sense, but don't use font/weight/italics to distinguish them from the others, because otherwise people will wonder why they're different and whether they're coming from the same place.
  • Use hover-over to show the phylorefs resolving to that node.

@gaurav
Copy link
Member Author

gaurav commented May 8, 2024

  • Visualizing multiple phylorefs on a single node or edge in Nexus goes beyond phyloreferencing.

@gaurav
Copy link
Member Author

gaurav commented Aug 28, 2024

  • For branch-based phyloreference, we could add a symbol to the clade, and then add a note underneath the phylogeny to say that this is clade extends up the parent branch.
    • Note that qualifiers can render a node-based clade into a branch-based clade, so we might want to look for "maximum" or other text in the definition.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant