Correct empty occurenceID so that it is blank, not urn:catalog:::
#148
+239
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We previously ignored the occurrenceID if it was an empty string, and "constructed" an occurrenceID from the other components. This PR modifies that behavior so that an occurrenceID set to a blank string will be treated as an empty occurrenceID -- only a specimen missing an occurrenceID entirely will have one constructed based on the other components. It also adds a test for this functionality.
It also replaces one use of
substr()(now deprecated) withsubstring(), updates the OpenTree version in a test that would otherwise fail, and adds the@shinnn/eslint-configpackage, which is needed now for some reason.Closes #145.