-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add specimen and taxon circumscription #75
Conversation
7f479d4
to
660f531
Compare
This file contains examples of a specimen and a taxon circumscription.
6676b5f
to
48a6d0c
Compare
This is to fix a bug with how logical expressions are generated when there are multiple external specifiers.
@gaurav did you forget to mark this one ready for review, or did you find you have to return it to draft stage temporarily? |
@hlapp Oops, yes, I forgot to mark it ready for review! My bad. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Look OK. See inline comment. And you still haven't explained to me (or maybe you have and I don't remember where?) why we are using the development version of the Phyx context.
remainingExternals.forEach((externalTU) => { | ||
intersectionExprs.push({ | ||
'@type': 'owl:Restriction', | ||
onProperty: 'obo:CDAO_0000144', // has_Ancestor |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that there's a property has_outside_TU
for this in the next release of the Phyloref Ontology: https://github.com/phyloref/phyloref-ontology/blob/master/phyloref.ofn#L38
Not sure whether using it should be a downstream change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, I forgot about that property! I've opened an issue to make the change in Phyx.js once the new version of the Phyloref Ontology has been released: #83.
Thanks, Hilmar!
I tried to answer this question in #72 (comment) after you asked it here, but if you'd like me to document this in a README file in the |
I think it would indeed be good to have that documented somewhere. That the question has already come up repeatedly indicates that before too long it will again, and so it seems useful to write this down so we don't have to dig around for the answer. |
Sounds good! I've written them up in PR #84. |
This PR incorporates two phyloreferences from Fisher et al, 2007, which include examples of specimens and a taxon circumscribed by a publication, as well as one of the phylogenies from that paper for testing. In doing this, I found a bug with how phylorefs with external specifiers were being generated when there are multiple external specifiers, and rewrote the algorithm to eliminate this bug. I also added a example file
example_five_external_specifiers.json
, which has a phyloreference with five external specifiers, just to make sure those logical expressions are being generated correctly.It also includes a minor fix to error reporting in
phyx2owl.js
.Should be merged after PR #79 and PR #72.