Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block io_uring without networking exception #34

Merged
merged 2 commits into from
Aug 29, 2023
Merged

Block io_uring without networking exception #34

merged 2 commits into from
Aug 29, 2023

Conversation

cd-work
Copy link
Collaborator

@cd-work cd-work commented Aug 28, 2023

This patch blocks all io_uring syscalls when the sandbox does not have full networking permissions.

Closes #32.


This fixes #32 to ensure the issue can be resolved immediately. For the proposed change from blacklist to whitelist I've opened a separate issue: #33.

This patch blocks all `io_uring` syscalls when the sandbox does not have
full networking permissions.

Closes #32.
Copy link

@louislang louislang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems reasonable to me! 👍

Copy link
Contributor

@maxrake maxrake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like all three io_uring syscalls are accounted for. The tests appear to verify the intended behavior. LGTM.

Copy link

@mrcnski mrcnski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@cd-work cd-work merged commit 282559c into main Aug 29, 2023
9 checks passed
@cd-work cd-work deleted the io_uringnt branch August 29, 2023 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Potential ways to get around networking sandbox
4 participants