Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lockfile_generator module name cleanup #1080

Closed
kylewillmon opened this issue May 8, 2023 · 1 comment · Fixed by #1098
Closed

lockfile_generator module name cleanup #1080

kylewillmon opened this issue May 8, 2023 · 1 comment · Fixed by #1098
Assignees

Comments

@kylewillmon
Copy link
Contributor

Here are the current modules and the commands that they use to generate lockfiles

> grep -r 'Command::new' lockfile_generator/src
lockfile_generator/src/npm.rs:        let mut command = Command::new("npm");
lockfile_generator/src/poetry.rs:        let mut command = Command::new("poetry");
lockfile_generator/src/cargo.rs:        let mut command = Command::new("cargo");
lockfile_generator/src/bundler.rs:        let mut command = Command::new("bundle");
lockfile_generator/src/pip.rs:        let mut command = Command::new("pipenv");
lockfile_generator/src/python_requirements.rs:        let mut command = Command::new("pip-compile");
lockfile_generator/src/maven.rs:        let mut command = Command::new("mvn");
lockfile_generator/src/go.rs:        let mut command = Command::new("go");
lockfile_generator/src/gradle.rs:        let mut command = Command::new("gradle");
lockfile_generator/src/yarn.rs:        let mut command = Command::new("yarn");

pip.rs calling pipenv is particularly misleading. This issue will track improving these names.

Originally posted by @maxrake in #1075 (comment)

@kylewillmon
Copy link
Contributor Author

If we name the files after the project that contains the tool, we would need to rename just these two files:

  • pip.rs -> pipenv.rs
  • python_requirements.rs -> pip_tools.rs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant