Fix use of pip-compile
#1075
Merged
Fix use of pip-compile
#1075
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxrake
requested changes
May 5, 2023
There was a problem hiding this comment.
A few suggested changes are requested. More testing is needed on the newly added Python manifest files. It may be that pip-compile has an issue with the instances of manifests used during my testing...but I will check on that next week when I get back into this.
cd-work
requested changes
May 8, 2023
maxrake
previously approved these changes
May 9, 2023
cd-work
previously approved these changes
May 9, 2023
Keep `poetry` as the default generator for `pyproject.toml` files because it is very common. But allow the user to use `-t pip` for other backends (requires `pip-compile`)
The command is not run from the same working directory, so using relative paths was causing failures.
kylewillmon
commented
May 9, 2023
maxrake
previously approved these changes
May 9, 2023
cd-work
approved these changes
May 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch updates our usage of
pip-compileto:requirements.in,setup.cfg,setup.py, andpyproject.toml