Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannot use deno on x86_64-unknown-linux-musl #426

Closed
kylewillmon opened this issue May 25, 2022 · 0 comments · Fixed by #624
Closed

Cannot use deno on x86_64-unknown-linux-musl #426

kylewillmon opened this issue May 25, 2022 · 0 comments · Fixed by #624
Assignees
@cd-work
Labels
bug Something isn't working extensions Phylum CLI extensions high priority Should be handled immediately
Milestone
Extensions MVP

Comments

@kylewillmon
Copy link
Contributor

As seen in this CI build, building deno fails for x86_64-unknown-linux-musl targets. This is because rusty_v8 does not support this target (see denoland/rusty_v8#49).
@kylewillmon kylewillmon added bug Something isn't working high priority Should be handled immediately extensions Phylum CLI extensions labels May 25, 2022
kylewillmon added a commit that referenced this issue May 25, 2022
@kylewillmon
Only use deno with the extensions feature
0483eca 
Unfortunately, it looks like the deno crates we are using fail to build
on x86_64-unknown-linux-musl... That is now recorded in #426, but in the
meantime, this change avoids including deno in our default builds
@kylewillmon kylewillmon mentioned this issue May 25, 2022
Merged
kylewillmon added a commit that referenced this issue May 26, 2022
@kylewillmon
Only use deno with the extensions feature (#427)
295eb08 
Unfortunately, it looks like the deno crates we are using fail to build
on x86_64-unknown-linux-musl... That is now recorded in #426, but in the
meantime, this change avoids including deno in our default builds
@cd-work cd-work self-assigned this May 31, 2022
@cd-work cd-work mentioned this issue Jun 3, 2022
Closed
@kylewillmon kylewillmon added this to the Extensions MVP milestone Jul 8, 2022
@kylewillmon kylewillmon mentioned this issue Jul 8, 2022
Closed
@cd-work cd-work mentioned this issue Aug 12, 2022
Merged
cd-work added a commit that referenced this issue Aug 17, 2022
@andreaphylum @cd-work
Move from musl to glibc for release builds
de3bd27 
Closes #426.

Co-authored-by: Christian Duerr <chris.durr@phylum.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cd-work cd-work

Labels
bug Something isn't working extensions Phylum CLI extensions high priority Should be handled immediately
Projects
None yet
Milestone
Extensions MVP
Development

Successfully merging a pull request may close this issue.

Transitioning away from musl phylum-dev/cli
2 participants
@kylewillmon @cd-work