Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add poetry lockfile v2 support #780

Merged
merged 3 commits into from
Oct 28, 2022
Merged

Add poetry lockfile v2 support #780

merged 3 commits into from
Oct 28, 2022

Conversation

cd-work
Copy link
Contributor

@cd-work cd-work commented Oct 26, 2022

This adds tests and documentation for supporting v2 of the poetry lockfile.

There are no changes to our parser, since none of the v2 changes affect the packages or their versions.

Closes #761.

@cd-work cd-work requested a review from a team as a code owner October 26, 2022 16:58
@cd-work cd-work requested a review from maxrake October 26, 2022 16:58
Copy link
Contributor

@maxrake maxrake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The warning in lockfile/src/python.rs should be updated now that version 1 and 2 of the poetry lockfile format is known to be supported.

Otherwise, things look good.

maxrake
maxrake previously approved these changes Oct 27, 2022
Copy link
Contributor

@maxrake maxrake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A slight debug log message tweak would help.

lockfile/src/python.rs Outdated Show resolved Hide resolved
This adds tests and documentation for supporting v2 of the poetry
lockfile.

There are no changes to our parser, since none of the v2 changes affect
the packages or their versions.

Closes #761.
Copy link
Contributor

@maxrake maxrake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cd-work cd-work merged commit f7b97b1 into main Oct 28, 2022
@cd-work cd-work deleted the poetry_v2 branch October 28, 2022 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support poetry lockfile version 2.0
2 participants