Skip to content

Commit

Permalink
fix: include phylum-ci.exe in release artifacts (#477)
Browse files Browse the repository at this point in the history
This change corrects a bug in the release workflow where the
`phylum-ci.exe` artifact is not published to the newly created GitHub
release. The `python-semantic-release` tool has the following config, in
`pyproject.toml`, for publishing artifacts by pattern:

```
[tool.semantic_release.publish]
dist_glob_patterns = ["dist/*", "build/phylum-ci.exe"]
```

The issue was that the `actions/upload-artifact` step used
`phylum-ci.exe` as the artifact name, which resulted in the following
directory structure for the corresponding `actions/download-artifact`
step:

`./phylum-ci.exe/phylum-ci.exe`

This clearly won't match the glob pattern of `build/phylum-ci.exe`. So,
this change is a simple one: change the upload artifact name to `build`
so that the downloaded artifact will exist at `./build/phylum-ci.exe`.
  • Loading branch information
maxrake authored Oct 2, 2024
1 parent 81aceec commit 23c1e28
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -199,7 +199,7 @@ jobs:
if: always()
uses: actions/upload-artifact@50769540e7f4bd5e21e526ee35c689e35e0d6874 # v4.4.0
with:
name: phylum-ci.exe
name: build
path: ./build/phylum-ci.exe
if-no-files-found: error

Expand Down

0 comments on commit 23c1e28

Please sign in to comment.