Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing titles and descriptions to regos that were missing them #11

Closed
wants to merge 1 commit into from

Conversation

louislang
Copy link
Contributor

No description provided.

@matt-phylum
Copy link
Contributor

I thought we deleted these three policies?

@louislang
Copy link
Contributor Author

If we did, we should delete this and remove from prod. But when I first pulled this repo and uploaded using this script, they were present in the clone.

@matt-phylum
Copy link
Contributor

default.rego isn't the default anymore. It's been replaced by the new default set.

I think license_agpl.rego has been replaced by copyleft_license.rego. copyleft_license is more general and uses an issue tag instead of looking at the license string with regular expressions.

per_domain.rego was more of an example of how to write a custom policy than a policy that we could recommend to users via the policy store. It's hard to explain what it does or why you would want a reusable policy that does specifically that, especially now that we support combining policies.

It looks like they're still in the repo, so we could use this PR to remove them.

@furi0us333
Copy link
Contributor

@matt-phylum is correct. I am closing this PR in favor or removing them via #12

@furi0us333 furi0us333 closed this Jul 29, 2024
@furi0us333 furi0us333 deleted the louis/add-missing-titles branch July 29, 2024 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants