Fixed a bug where defaults would be overwritten #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oops, I have something in progress which fixes some of these too. Lemme put it up and we can compare notes =) |
|
Well... mine's broken anyway :-) |
|
This is dependent on #87 being merged. |
In the previous case, defaults in the cli args would be overwritten and replaced with a null value even when no env vars were set.
drewsonne
force-pushed
the
feature/specific-env-vars
branch
from
9db2c65
to
2e3e7ae
Compare
|
Should this one be closed? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the previous case, defaults in the cli args would be overwritten and replaced with a null value even when no env vars were set.
I think this is a problem I introduced with #77 . This is pointed out in #83 .