Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes incorrect handling of cli and config file parameter merging #87

Merged
merged 11 commits into from
Apr 21, 2018
Merged

Fixes incorrect handling of cli and config file parameter merging #87

merged 11 commits into from
Apr 21, 2018

Commits on Apr 21, 2018

  1. The config value should always fall back to default

    @drewsonne
    drewsonne committed Apr 21, 2018
    Configuration menu
    Copy the full SHA
    f901146 View commit details
    Browse the repository at this point in the history

  2. Specify defaults section as discussed in physera#88

    @drewsonne
    drewsonne committed Apr 21, 2018
    Configuration menu
    Copy the full SHA
    68b1733 View commit details
    Browse the repository at this point in the history

  3. Add more verbose error handling

    @drewsonne
    drewsonne committed Apr 21, 2018
    Configuration menu
    Copy the full SHA
    ac23539 View commit details
    Browse the repository at this point in the history

  4. Don’t include empty values in overrides

    @drewsonne
    drewsonne committed Apr 21, 2018
    Configuration menu
    Copy the full SHA
    0cccc06 View commit details
    Browse the repository at this point in the history

  5. Moved defaults from cli into config file

    @drewsonne
    drewsonne committed Apr 21, 2018
    Configuration menu
    Copy the full SHA
    073d080 View commit details
    Browse the repository at this point in the history

  6. Fix flake8

    @drewsonne
    drewsonne committed Apr 21, 2018
    Configuration menu
    Copy the full SHA
    6a2a886 View commit details
    Browse the repository at this point in the history

  7. Fix test cases

    @drewsonne
    drewsonne committed Apr 21, 2018
    Configuration menu
    Copy the full SHA
    22fd7a9 View commit details
    Browse the repository at this point in the history

  8. Handle defaults so they are not written to the config

    @drewsonne
    drewsonne committed Apr 21, 2018
    Configuration menu
    Copy the full SHA
    e5c7b70 View commit details
    Browse the repository at this point in the history

  9. Updated test cases to handle config precedence

    @drewsonne
    drewsonne committed Apr 21, 2018
    Configuration menu
    Copy the full SHA
    ba49e0c View commit details
    Browse the repository at this point in the history

  10. Removed defaults check

    @drewsonne
    drewsonne committed Apr 21, 2018
    Configuration menu
    Copy the full SHA
    35d7361 View commit details
    Browse the repository at this point in the history

  11. Make sure duration is an int

    @drewsonne
    drewsonne committed Apr 21, 2018
    Configuration menu
    Copy the full SHA
    1802298 View commit details
    Browse the repository at this point in the history