New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

I2C pull up resistance variables - type, name, configuration #90

Open

btsouts opened this issue Jun 2, 2020 · 1 comment

Labels

Bug

Contributor

btsouts commented Jun 2, 2020

Describe the bug
Variables for I2C pull up resistance appear in various places with different type and semantics.

Variable menuI2cPullupValue in main functions is uint16_t and intended to be the I2C resistance value in Ohms.

Variable pullupValue in configureI2Cpins function is uint8_t and corresponds to the tap positions of the ISL23425 DCPs.

Required changes

There are currently two ISL23425 DCPs which are configured with the same tap position value using configureI2Cpins function. We should modify the function to be able to take two values.
A similar approach for menuI2cPullupValue, since there are two DCPs.
We should add a function to map the menuI2cPullupValue Ohms value to ISL23425 DCP tap position.

btsouts added the Bug label

Member

phillipstanleymarbell commented Jun 4, 2020

See also #50

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment