Conversation
|
Hey, your PR seems very interesting, but It's too complex to understand through screenshots. |
|
And there is also a conflict with package-lock.json |
|
Hello @physicshub, I have made the changes and resolved the conflicts as well. The change can be merged properly now. Thanks for letting me know. |
|
Hey sorry for late reply, there is something else that you should change:
The system that you made is beautiful, I love the idea of pre-made templates that you can apply, would be awesome one day to create these template also for more sims. |
|
Hey Matt, apologies for the errors found. I will fix these errors today and update the PR for this issue. Thank you for bringing this problem into account so, I can work and improve myself by working into this. |
|
Hey Matt, I have done the changes. I think you can commit the changes now. Thanks again for letting me know my mistakes. |
|
Thank you, can I see how it looks now the page? |
|
So, it looks similar but, I have done the formatting issues and also fixed the issues with the package.json file. I have kept the styling of the test simulation similar as it is a test simulation, so I have kept it little bit differently so that it will be easier to update or work on in the future. Also, I was trying to fix the lint and format checks but, it is not getting fixed. I will continue to fix that though. |
|
Thank you for fixning this. Sorry for the delay, I'm very busy with Erasmus+ program at the moment. I'll see your changes at the end of the week when my french twin will go away |
|
Sure that's not an issue. Thank you. |
|
Hey man today I'll review your PR, can you confirm that the UI that you sent to me is updated and it shows all the changes you made? |
|
Hello Matt, So, I have not changed the UI as I mentioned before as it is a test simulation so, I have kept it different from others to make it easier to maintain and work on in the future. Also, for the conflicts with the package.json file and the prettier formatting issues, both of these are solved. Thanks again for considering me for this issue. |
|
Hey man I'm sorry to tell you this, but as I announced in Discussion and on Discord, I've pushed some changes I've been wanting to make for weeks. So, in addition to a lot of other bugs, there are some conflicts that need to be resolved. Can you see if you can fix the conflicts? Sorry for this. You can see all the details on the Discord announcement |
📘 Pull Request Template – PhysicsHub
Thank you for contributing to PhysicsHub!
Please complete the sections below to help us review your pull request efficiently.
🔍 Description
This PR implements comprehensive improvements to the Test Simulation (#120), focusing on UI/UX enhancements, educational features, and bug fixes.
🎯 Main Changes
1. UI/UX Improvements
2. New Educational Components
CollapsibleSection.tsx- Reusable collapsible section component for organizing educational contentGuidedExperiments.tsx- Component for displaying and applying predefined experimentsLearningObjectives.tsx- Component for displaying learning goals and key variablesPhysicsEquations.tsx- Component for displaying relevant physics equationsPhysicsWarnings.tsx- Component for displaying physics-related warningsEducationalTheorySection.tsx- Comprehensive educational content section3. Bug Fixes
4. Code Quality
🔧 Technical Details
📸 Visual Changes
✅ Testing
🎓 Educational Impact
This PR enhances the educational value of the Test Simulation by:
Related Issue: Test Simulation #120
Type: Enhancement / Bug Fix / UI/UX Improvement
Closes #120 (if applicable)
✅ Checklist
Before requesting a review, please ensure that you have:
npm run dev)🎨 Visual Changes (if UI-related)
PhysicsHub - Test for benchmarks - Google Chrome 2026-02-02 16-22-07.zip
📂 Type of Change
🧩 Additional Notes for Reviewers