Improving trigger pictures.

[smoia]

So far, the trigger picture created around this line have a simple title, and show the expected start and expected end of the sequence.
It would be nice to:

• add the name of the corresponding tsv output file in the title
• add a third subplot in the second row, that shows the last trigger
• rescale differently the Y axis in the first row, maybe the higher between twice the max value in the trigger array and three times the threshold?

[vinferrer]

I think this is a good first issue but since no one aproach it maybe we should restart it stefano

[vinferrer]

@smoia

[smoia]

No rush on this, but yes, we can restart it. Wanna take care of it?

[vinferrer]

one question. What's the difference between the two plots in the second row?

[smoia]

They should be different - showing the first and the last TR trigger. It's made so that if the sequence is long but you are asking the program to detect beginning and length of the sequence, you can see how the program performed and eventually correct issues.
How did you obtain this output?

[vinferrer]

phys2bids -in Test_belt_pulse_multifreq.txt -chtrig 3
I change the title only everything else comes from the master branch

[smoia]

I see. In this case, the fact that the two subplots are the same might arise from the fact that there is no start and length check. We could add a flag, to not draw the second line when this option is not required - or to expand the plot on the left to the whole line.

another thing would be to substitute the time line (orange) with something else - maybe a semi-transparent rectangle on the background?

[vinferrer]

Well I am checking the code and the repetition of the plot it's due to the fact that you are plotting the same exact line in both plots:

    subplot = fig.add_subplot(223)
    subplot.set_xlim([-options.tr * 4, options.tr * 4])
    subplot.set_ylim([-0.2, options.thr * 3])
    subplot.secondary_xaxis('top', functions=(time2ntr, ntr2time))
    subplot.plot(time, trigger, '-', time, time, '-')
    subplot = fig.add_subplot(224)
    subplot.set_xlim([options.tr * (options.num_timepoints_expected - 4),
                      options.tr * (options.num_timepoints_expected + 4)])
    subplot.set_ylim([-0.2, options.thr * 3])
    subplot.secondary_xaxis('top', functions=(time2ntr, ntr2time))
    subplot.plot(time, trigger, '-', time, time, '-')

[vinferrer]

I see no difference between the 5 and the last line

[vinferrer]

Oh, sry i see the xlim now

[vinferrer]

Yeah so basically options.num_timepoints_expected is zero in this case

[vinferrer]

So I have changed the function a bit and now this is the output with the file:

[vinferrer]

I can share the new code by PR but maybe we should discuss the third plot. Why do you wanna plot the last trigger only? this can be seen in the second figure