Generalize weight used in dijkstra algorithm #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbaldu
force-pushed
the
feature_general_dijkstra
branch
from
caf57ea
to
f37d1ea
Compare
Grufoony
approved these changes
May 2, 2024
| @@ -0,0 +1,18 @@ | |||
|
|
|||
| #ifndef dijkstra_weights_hpp | |||
There was a problem hiding this comment.
Shall we start using #pragma once?
There was a problem hiding this comment.
We should do a PR where we convert all of them
| @@ -778,10 +794,10 @@ namespace dsm { | |||
| if (visitedNodes.find(neighbour.first) != visitedNodes.end()) { | |||
| continue; | |||
| } | |||
| double streetLength = (*(this->street(source, neighbour.first)))->length(); | |||
| double streetWeight = getStreetWeight(this, source, neighbour.first); | |||
There was a problem hiding this comment.
Is double type a fair assumption?
We could make it more general... but effectively sounds like more effort than utility.
|
Please @sbaldu remember to update the project version |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #174 +/- ##
=======================================
Coverage 94.47% 94.48%
=======================================
Files 17 18 +1
Lines 2897 2900 +3
Branches 281 281
=======================================
+ Hits 2737 2740 +3
Misses 160 160
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.