Remove normDensity function from Street class
#216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -1364,7 +1364,7 @@ | |||
| const auto& agent{this->m_agents[agentId]}; | |||
| const auto& street{this->m_graph.streetSet()[agent->streetId().value()]}; | |||
| double speed{street->maxSpeed() * | |||
| (1. - this->m_minSpeedRateo * street->normDensity())}; | |||
| (1. - this->m_minSpeedRateo * street->density(true))}; | |||
Check notice
Code scanning / Cppcheck (reported by Codacy)
MISRA 12.1 rule Note
| @@ -153,6 +153,11 @@ | |||
| return nAgents; | |||
| } | |||
|
|
|||
| double Street::density(bool normalized) const { | |||
| return normalized ? nAgents() / static_cast<double>(m_capacity) | |||
| : nAgents() / (m_len * m_nLanes); | |||
Check notice
Code scanning / Cppcheck (reported by Codacy)
MISRA 10.4 rule Note
| /// @brief Get the street's normalized density | ||
| /// @return double, The street's normalized density | ||
| double normDensity() const { return nAgents() / static_cast<double>(m_capacity); } | ||
| double density(bool normalized = false) const; |
Check notice
Code scanning / Cppcheck (reported by Codacy)
MISRA 13.4 rule Note
| /// @brief Get the street's normalized density | ||
| /// @return double, The street's normalized density | ||
| double normDensity() const { return nAgents() / static_cast<double>(m_capacity); } | ||
| double density(bool normalized = false) const; |
Check notice
Code scanning / Cppcheck (reported by Codacy)
MISRA 17.8 rule Note
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.