classes: fitimage: allow configuration of deployed filenames #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
classes/fitimage.bbclass
Outdated
| @@ -91,7 +91,10 @@ FITIMAGE_NO_DTB_OVERLAYS ??= "false" | |||
| FITIMAGE_NO_DTB_OVERLAYS[type] = "boolean" | |||
|
|
|||
| FITIMAGE_IMAGE_SUFFIX ??= "" | |||
| FITIMAGE_IMAGE_LINK_NAME ??= "fitImage" | |||
| FITIMAGE_IMAGE_BASE_NAME ??= "fitImage-${PN}-${PV}-${PR}-${MACHINE}${IMAGE_VERSION_SUFFIX}${FITIMAGE_IMAGE_SUFFIX}" | |||
| FITIMAGE_IMAGE_LINK_NAME ??= "${PN}-${MACHINE}${FITIMAGE_IMAGE_SUFFIX}" | |||
There was a problem hiding this comment.
Hello Johannes,
thank you for this patch.
At the moment the soft link name fitImage is used for the creation of wic and partup image.
You can see it in the declaration of IMAGE_BOOT_FILES in the machine config files.
The bootloader use the name fitImage for loading the image, too.
So we need a soft link to fitImage.
Can you set the FITIMAGE_IMAGE_LINK_NAME ??= fitImage as default?
Refactor the do_deploy to allow a class inheriting recipe to change the file- and symlink-names of the created artifacts through the new variables: FITIMAGE_IMAGE_BASE_NAME for the fitimage binary FITIMAGE_IMAGE_LINK_NAME FITIMAGE_ITS_BASE_NAME and the manifest file FITIMAGE_ITS_LINK_NAME Signed-off-by: Johannes Schneider <johannes.schneider@leica-geosystems.com>
js731ca
force-pushed
the
scjoh/fitimage-filenames
branch
from
8f4cd03 to
b4a2979
Compare
|
v1.1: reverting back of the default: |
motto-phytec
approved these changes
Nov 19, 2024
|
applied internally, will go through ci, build, testing and be public in a couple of days |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor the do_deploy to allow a class inheriting recipe to change the file- and symlink-names of the created artifacts through the new variables:
FITIMAGE_IMAGE_BASE_NAME for the fitimage binary
FITIMAGE_IMAGE_LINK_NAME
FITIMAGE_ITS_BASE_NAME and the manifest file
FITIMAGE_ITS_LINK_NAME