Merge pull request #445 from pi-hole/hotfix/v4.1.2

Fix segfault in FTL_reply corresponding to name being null
pi-hole · Dec 21, 2018 · b06eedf · b06eedf
2 parents f5f331b + ab9dc6e
commit b06eedf
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/dnsmasq_interface.c b/dnsmasq_interface.c
@@ -425,7 +425,7 @@ void FTL_reply(unsigned short flags, char *name, struct all_addr *addr, int id)
  // Determine if this reply is an exact match for the queried domain
  int domainID = queries[i].domainID;
  validate_access("domains", domainID, true, __LINE__, __FUNCTION__, __FILE__);
- bool isExactMatch = (strcmp(domains[domainID].domain, name) == 0);
+ bool isExactMatch = (name != NULL && strcmp(domains[domainID].domain, name) == 0);
 
  if((flags & F_CONFIG) && isExactMatch && !queries[i].complete)
  {