Worked on review comments

Signed-off-by: DL6ER <dl6er@dl6er.de>
pi-hole · Dec 28, 2017 · dbc9457 · dbc9457
1 parent 3346a84
commit dbc9457
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 13 deletions.
diff --git a/parser.c b/parser.c
@@ -589,7 +589,7 @@ void process_pihole_log(int file)
  if(dnsmasqID < 0)
  continue;
 
- // Save forwardID in corresponding query indentified by dnsmasq's ID
+ // Save status in corresponding query indentified by dnsmasq's ID
  bool found = false;
  for(i=0; i<counters.queries; i++)
  {
@@ -647,7 +647,7 @@ void process_pihole_log(int file)
  continue;
  }
 
- // Save forwardID in corresponding query indentified by dnsmasq's ID
+ // Save status and forwardID in corresponding query indentified by dnsmasq's ID
  bool found = false;
  for(i=0; i<counters.queries; i++)
  {
@@ -720,7 +720,7 @@ void process_pihole_log(int file)
  if(dnsmasqID < 0)
  continue;
 
- // Save forwardID in corresponding query indentified by dnsmasq's ID
+ // Save status in corresponding query indentified by dnsmasq's ID
  bool found = false;
  for(i=0; i<counters.queries; i++)
  {
@@ -758,7 +758,7 @@ void process_pihole_log(int file)
  else if(strstr(readbuffer," config ") != NULL && strstr(readbuffer," is ") != NULL)
  {
  // Check query for invalid characters
- if(!checkQuery(readbuffer, "gravity.list"))
+ if(!checkQuery(readbuffer, "config"))
  continue;
 
  // Get dnsmasq's ID for this transaction
@@ -767,7 +767,7 @@ void process_pihole_log(int file)
  if(dnsmasqID < 0)
  continue;
 
- // Save forwardID in corresponding query indentified by dnsmasq's ID
+ // Save status in corresponding query indentified by dnsmasq's ID
  bool found = false;
  for(i=0; i<counters.queries; i++)
  {
@@ -832,7 +832,7 @@ void process_pihole_log(int file)
  if(dnsmasqID < 0)
  continue;
 
- // Save forwardID in corresponding query indentified by dnsmasq's ID
+ // Save status in corresponding query indentified by dnsmasq's ID
  bool found = false;
  for(i=0; i<counters.queries; i++)
  {

diff --git a/request.c b/request.c
@@ -1195,13 +1195,6 @@ void getUnknownQueries(int *sock)
 {
  char server_message[SOCKETBUFFERLEN];
 
- if(!debug)
- {
- sprintf(server_message,"For safety reasons, the command is only available in debugging mode!\n");
- swrite(server_message, *sock);
- return;
- }
-
  int i;
  for(i=0; i < counters.queries; i++)
  {