Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added missing NS query type to getQueryTypes() #1007

Merged
merged 2 commits into from
Dec 28, 2020
Merged

Added missing NS query type to getQueryTypes() #1007

merged 2 commits into from
Dec 28, 2020

Conversation

Daxtorim
Copy link
Contributor

@Daxtorim Daxtorim commented Dec 27, 2020

Signed-off-by: Fabian Preuß preuss_fabian@gmx.de

By submitting this pull request, I confirm the following:

  • I have read and understood the contributors guide.
  • I have checked that another pull request for this purpose does not exist.
  • I have considered, and confirmed that this submission will be valuable to others.
  • I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • I give this submission freely, and claim no ownership to its content.

How familiar are you with the codebase?: 2


What does this PR aim to fix?:

When the Query Types chart tries to fetch the query types, it does not receive info about the "NS" type. This results in two issues:

  1. The "NS" type is completely missing from the chart. Tooltips do not add up to 100%.
  2. The legend of the Query Types chart on the dashboard allows you to filter the Query Log for a specific query type. This works fine for all types except "OTHER". Clicking on "OTHER" filters the Query Log for the type "NS". There is a mismatch between the query type id that the chart forwards to the Query Log and the one FTL will ultimately send back.

What FTL uses:
["A (IPv4)", "AAAA (IPv6)", "ANY", "SRV", "SOA", "PTR", "TXT", "NAPTR", "MX", "DS", "RRSIG", "DNSKEY", "NS", "OTHER"]
What the chart receives:
["A (IPv4)", "AAAA (IPv6)", "ANY", "SRV", "SOA", "PTR", "TXT", "NAPTR", "MX", "DS", "RRSIG", "DNSKEY", "OTHER"]

How does this PR accomplish the above?:

Added query type "NS" to getQueryTypes().

Signed-off-by: Fabian Preuß <preuss_fabian@gmx.de>
Signed-off-by: Fabian Preuß <preuss_fabian@gmx.de>
Copy link
Member

@DL6ER DL6ER left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yes, thanks!

Note: There are plans to add more generic support for query types but it is not yet clear what to do with database entries (converting the entire database would likely take quite some time).

@DL6ER DL6ER merged commit 5f60ba9 into pi-hole:development Dec 28, 2020
@PromoFaux
Copy link
Member

Ah... that reminds me

@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/pi-hole-core-v5-2-3-web-v5-3-and-ftl-v5-4-released/43009/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants