Implement support for displaying exact type instead of just "OTHER" #1013
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm the following:
How familiar are you with the codebase?:
10
Implement support for displaying exact type instead of the catch-them-all category
OTHER
. TheOTHER
category is still used when it comes to computing statistics to ensure your chart's legend does not explode.Example:
results in:
(note that type 65 is correctly translated into the named type
HTTPS
rather than showingTYPE65
)And the database contains the expected (
16
=HTTPS
mapped status,166
=TYPE66
with offset 100)No changed to core of AdminLTE are necessary for this to work. A small change to the long-term queries page will be needed to handle these offset types still as
OTHER
.