Circle CI: skip uploading build artifacts on forks

[bershanskiy]

Signed-off-by: Anton Bershanskiy 45960703+bershanskiy@users.noreply.github.com

By submitting this pull request, I confirm the following (please check boxes, eg [X]) Failure to fill the template will close your PR:

Please submit all pull requests against the development branch. Failure to do so will delay or deny your request

• I have read and understood the contributors guide.
• I have checked that another pull request for this purpose does not exist.
• I have considered, and confirmed that this submission will be valuable to others.
• I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
• I give this submission freely, and claim no ownership to its content.

How familiar are you with the codebase?: {replace this text with a number from 1 to 10, with 1 being not familiar, and 10 being very familiar}

1

---

When external contributor (like me) forks FTL and enables Circle CI on it, Circle CI tries to upload artifacts to Pi-Hole's FTP server. Of course, upload fails and fails the whole workflow and skips actual test.

Example run before this change:
https://app.circleci.com/pipelines/github/bershanskiy/FTL/1/workflows/9d0fd821-4a83-4b63-826f-60948822beda/jobs/2

Example run after this change:
https://app.circleci.com/pipelines/github/bershanskiy/FTL/2/workflows/32643484-69c6-4465-88d0-8105f7b8a6c8/jobs/15

This template was created based on the work of udemy-dl.

[bershanskiy]

I think Circle CI is did not run this build out of caution because it changes the workflow.

[DL6ER]

Thanks. This is something we haven't considered with all consequences, it seems.

[bershanskiy]

I just checked and this change works as expected (it fixed my Circle CI builds; official repo builds still upload artifacts).

[pralor-bot]

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/pi-hole-ftl-v5-8-web-v5-5-and-core-v5-3-released/46237/1