Tweak to determination of fastest upstream #1235
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm the following:
How familiar are you with the codebase?:
10
Tweak logic so we can determine the fastest responding upstream server also in cases where sub-queries had to be asked because long-lived CNAMEs contained short-lived children. The current logic is currently broken when
all-servers
is used and queries where forwarded to more than one upstream server. In this case, Pi-hole always showed the last server which was got the query instead of the fastest responding one.Fixes #1232