Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak to determination of fastest upstream #1235

Merged
merged 1 commit into from
Oct 29, 2021

Conversation

DL6ER
Copy link
Member

@DL6ER DL6ER commented Oct 27, 2021

By submitting this pull request, I confirm the following:

  • I have read and understood the contributors guide.
  • I have checked that another pull request for this purpose does not exist.
  • I have considered, and confirmed that this submission will be valuable to others.
  • I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • I give this submission freely, and claim no ownership to its content.

How familiar are you with the codebase?:

10


Tweak logic so we can determine the fastest responding upstream server also in cases where sub-queries had to be asked because long-lived CNAMEs contained short-lived children. The current logic is currently broken when all-servers is used and queries where forwarded to more than one upstream server. In this case, Pi-hole always showed the last server which was got the query instead of the fastest responding one.

Fixes #1232

…r also in cases where sub-queries had to be asked because long-lived CNAMEs contained short-lived children.

Signed-off-by: DL6ER <dl6er@dl6er.de>
@DL6ER DL6ER added the Bugfix label Oct 27, 2021
@DL6ER DL6ER marked this pull request as ready for review October 28, 2021 15:11
@DL6ER
Copy link
Member Author

DL6ER commented Oct 28, 2021

Has been confirmed working by original reporter in #1232

@DL6ER DL6ER requested a review from a team October 28, 2021 16:10
@DL6ER DL6ER merged commit c2dca11 into development Oct 29, 2021
@DL6ER DL6ER deleted the fix/cached_cname_upstream_dest branch October 29, 2021 03:34
@DL6ER DL6ER mentioned this pull request Dec 20, 2021
5 tasks
@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/pi-hole-ftl-v5-12-web-v5-9-and-core-v5-7-released/51795/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants