Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return DNS port on ">dns-port" telnet command #1264

Merged
merged 2 commits into from
Dec 29, 2021
Merged

Conversation

DL6ER
Copy link
Member

@DL6ER DL6ER commented Dec 28, 2021

By submitting this pull request, I confirm the following:

  • I have read and understood the contributors guide.
  • I have checked that another pull request for this purpose does not exist.
  • I have considered, and confirmed that this submission will be valuable to others.
  • I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • I give this submission freely, and claim no ownership to its content.

How familiar are you with the codebase?:

10


See title.

Example:

$ echo ">dns-port >quit" | nc 127.0.0.1 4711
53

Meant to be useful for pi-hole/pi-hole#4485. Can be closed without merging when not used there. Note that the port can also be 0 is someone decides to disable the DNS server part of Pi-hole (possible even when not useful).

Signed-off-by: DL6ER <dl6er@dl6er.de>
Signed-off-by: DL6ER <dl6er@dl6er.de>
@yubiuser
Copy link
Member

Documentation PR: pi-hole/docs#629

Copy link
Member

@yubiuser yubiuser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@DL6ER DL6ER merged commit e9db358 into development Dec 29, 2021
@DL6ER DL6ER deleted the new/telnet-dns-port branch December 29, 2021 10:09
@PromoFaux PromoFaux mentioned this pull request Jan 4, 2022
@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/pi-hole-ftl-v5-13-web-v5-10-and-core-v5-8-released/52254/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants