Check struct sizes on the CI instead of during compile-time #1329
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm the following:
How familiar are you with the codebase?:
10
Check struct sizes on the CI (in code) instead of during compile-time (using the preprocessor). This should resolve an issue reported on Discourse.
It adds an (undocumented) new flag
pihole-FTL --check-structs
that is supposed to be used by the tests. The exit code will tell if everything worked as expected (bash
-compatible: exit code 0 is success).