Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add clients over time data structure #134

Merged
merged 7 commits into from
Oct 10, 2017
Merged

Conversation

DL6ER
Copy link
Member

@DL6ER DL6ER commented Sep 22, 2017

By submitting this pull request, I confirm the following (please check boxes, eg [X]) Failure to fill the template will close your PR:

Please submit all pull requests against the development branch. Failure to do so will delay or deny your request

  • I have read and understood the contributors guide.
  • I have checked that another pull request for this purpose does not exist.
  • I have considered, and confirmed that this submission will be valuable to others.
  • I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • I give this submission freely, and claim no ownership to its content.

How familiar are you with the codebase?:

10


See pi-hole/web#583

This template was created based on the work of udemy-dl.

@DL6ER
Copy link
Member Author

DL6ER commented Sep 29, 2017

Apply API_EXCLUDE_CLIENTS filtering as suggested by @WaLLy3K in private communication.

No filtering:
screenshot at 2017-09-29 22-33-55

Assume I want to filter:

  • localhost (bright blue) as it is constantly active
  • desktop (darker blue starting around 20:00) just to demonstrate it works.

I apply the following filter:
screenshot at 2017-09-29 22-33-43
where I intentionally used the host name for localhost and the IP address for desktop to show that both can be used at liberty to identify individual clients.

The result with the above filter is:
screenshot at 2017-09-29 22-33-31

The contributions from localhost and desktop are now missing in the graph. Note that the colors between the two screenshots have changed as the chart generator isn't even aware of the existence of the two filtered clients.

This seems to be useful in some situations, e.g. when there is a very chatty device that likes to call home and hence totally ruins the overall statistics without filtering. In this situation, the new clients over time graph will be a good alternative to the main graph.

Signed-off-by: DL6ER <dl6er@dl6er.de>
Signed-off-by: DL6ER <dl6er@dl6er.de>

Conflicts:
	request.c
@AzureMarker
Copy link
Contributor

The web interface should change its description from just top clients to include this feature.

AzureMarker
AzureMarker previously approved these changes Sep 30, 2017
@WaLLy3K
Copy link

WaLLy3K commented Sep 30, 2017

Some of this is FTL's scope, other parts of this review are in scope for AdminLTE #583:

untitled

The popover gets cut off when there's more than a handful of clients, and there's an entry with a blank name - perhaps because there's two devices on my network which haven't had hostnames manually assigned to them via /etc/hosts

I also feel that for usability and readability's sake, that the devices should be sorted descending by the number of queries they've made. This makes it easier to hover over one data point, look at the top of the list and immediately say "Okay, the insane number of queries came from XYZ".

…tself for the sake of convenience (the output format is now similar to ">forward-names")

Signed-off-by: DL6ER <dl6er@dl6er.de>
@DL6ER DL6ER merged commit 06efbdf into development Oct 10, 2017
@DL6ER DL6ER deleted the new/clientsovertime branch October 10, 2017 17:06
@DL6ER DL6ER changed the title [WIP] Add clients over time data structure Add clients over time data structure Oct 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants