Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect pihole blocking status #143

Merged
merged 2 commits into from
Oct 25, 2017
Merged

Detect pihole blocking status #143

merged 2 commits into from
Oct 25, 2017

Conversation

DL6ER
Copy link
Member

@DL6ER DL6ER commented Oct 5, 2017

By submitting this pull request, I confirm the following (please check boxes, eg [X]) Failure to fill the template will close your PR:

Please submit all pull requests against the development branch. Failure to do so will delay or deny your request

  • I have read and understood the contributors guide.
  • I have checked that another pull request for this purpose does not exist.
  • I have considered, and confirmed that this submission will be valuable to others.
  • I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • I give this submission freely, and claim no ownership to its content.

How familiar are you with the codebase?:

10


Detect Pi-hole blocking status and return this on API request:

Enabled:

echo ">stats" | nc pi.hole 4711
domains_being_blocked 113207
dns_queries_today 13248
ads_blocked_today 302
ads_percentage_today 2.279589
unique_domains 584
queries_forwarded 4725
queries_cached 8221
clients_ever_seen 6
unique_clients 6
status enabled
---EOM---

Disabled:

echo ">stats" | nc pi.hole 4711
domains_being_blocked N/A
dns_queries_today 13248
ads_blocked_today 302
ads_percentage_today 2.279589
unique_domains 584
queries_forwarded 4725
queries_cached 8221
clients_ever_seen 6
unique_clients 6
status disabled
---EOM---

This template was created based on the work of udemy-dl.

Copy link

@WaLLy3K WaLLy3K left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected, however I'll need to make some changes to Chronometer to support N/A.

@DL6ER
Copy link
Member Author

DL6ER commented Oct 21, 2017

@WaLLy3K What's the status of the effects to Chronometer?

@WaLLy3K
Copy link

WaLLy3K commented Oct 21, 2017

Haven't had a chance to work on it, sadly. It isn't a big issue, but the one-line error does need to be silenced.

@DL6ER DL6ER added the ON HOLD label Oct 23, 2017
@DL6ER DL6ER removed the ON HOLD label Oct 25, 2017
@DL6ER DL6ER merged commit fbc5c6d into development Oct 25, 2017
@DL6ER DL6ER deleted the new/pihole_status_stats branch October 25, 2017 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants