Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pi-hole FTL v5.21 #1528

Merged
merged 13 commits into from
Feb 10, 2023
Merged

Pi-hole FTL v5.21 #1528

merged 13 commits into from
Feb 10, 2023

Conversation

DL6ER
Copy link
Member

@DL6ER DL6ER commented Feb 7, 2023

  • Update embedded dnsmasq to v2.89 (released yesterday)
    • Fix bug which can break the invariants on the order of a hash chain.
    • Add no-ident option for enhanced privacy (a Pi-hole contributed feature)
  • Extend Pi-hole regex extension querytype= to support multiple query types like ;querytype=A,AAAA (see our documentation update for further details: ;querytype=... list support docs#855)

simonkelley and others added 13 commits January 15, 2023 07:54
This is code which should never run, but if it does,
we now log information useful for debugging.

Signed-off-by: DL6ER <dl6er@dl6er.de>
Signed-off-by: DL6ER <dl6er@dl6er.de>
Signed-off-by: DL6ER <dl6er@dl6er.de>
If there are multiple cache records with the same name but different
F_REVERSE and/or F_IMMORTAL flags, the code added in fe9a134b could
concievable break the REVERSE-FORWARD-IMMORTAL order invariant.

Reproducing this is damn near impossible, but it is responsible
for rare and otherwise inexplicable reversion between 2.87 and 2.88
which manifests itself as a cache internal error. All observed
cases have depended on DNSSEC being enabled, but the bug could in
theory manifest itself without DNSSEC

Thanks to Timo van Roermund for reporting the bug and huge
efforts to isolate it.

Signed-off-by: DL6ER <dl6er@dl6er.de>
…abc;querytype=HTTPS,SVCB"

Signed-off-by: DL6ER <dl6er@dl6er.de>
sync: master to development
Signed-off-by: DL6ER <dl6er@dl6er.de>
Signed-off-by: DL6ER <dl6er@dl6er.de>
…A,MX). You can use the exclamation mark as before for inversion (querytype=!A) matches everything BUT type A queries. This has now been extended to be able to invert a list, too (like (querytype=!A,AAAA matches everything BUT A and AAAA queries)

Signed-off-by: DL6ER <dl6er@dl6er.de>
Signed-off-by: DL6ER <dl6er@dl6er.de>
Signed-off-by: DL6ER <dl6er@dl6er.de>
Update embedded dnsmasq to v2.89
@DL6ER DL6ER added the Release label Feb 7, 2023
@DL6ER DL6ER requested a review from a team February 7, 2023 18:47
@dschaper dschaper self-requested a review February 8, 2023 18:43
@PromoFaux PromoFaux merged commit f380afd into master Feb 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants