Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RISC-V 64-bit support and builds #1536

Merged
merged 1 commit into from
Mar 20, 2023
Merged

Add RISC-V 64-bit support and builds #1536

merged 1 commit into from
Mar 20, 2023

Conversation

MichaIng
Copy link
Contributor

@MichaIng MichaIng commented Mar 5, 2023

Thank you for your contribution to the Pi-hole Community!

Please read the comments below to help us consider your Pull Request.

We are all volunteers and completing the process outlined will help us review your commits quicker.

Please make sure you

  1. Base your code and PRs against the repositories developmental branch.
  2. Sign Off all commits as we enforce the DCO for all contributions
  3. Sign all your commits as they must have verified signatures
  4. File a pull request for any change that requires changes to our documentation at our documentation repo

What does this PR aim to accomplish?:

Adds support for RISC-V 64-bit architecture and FTL builds to CI.

How does this PR accomplish the above?:

Companion PRs:

Link documentation PRs if any are needed to support this PR:


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code and I have tested my changes.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)
  6. I have checked that another pull request for this purpose does not exist.
  7. I have considered, and confirmed that this submission will be valuable to others.
  8. I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  9. I give this submission freely, and claim no ownership to its content.

  • I have read the above and my PR is ready for review. Check this box to confirm

@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/ftl-risc-v-builds-support/61629/7

DL6ER added a commit that referenced this pull request Mar 5, 2023
Signed-off-by: DL6ER <dl6er@dl6er.de>
@MichaIng MichaIng marked this pull request as ready for review March 5, 2023 18:46
@DL6ER
Copy link
Member

DL6ER commented Mar 19, 2023

@MichaIng ghcr.io/pi-hole/ftl-build:v1.26-riscv64 is now available. I also have a PR to avoid the ❌ on the spell-check action but this hasn't landed in devlopment yet.

@DL6ER
Copy link
Member

DL6ER commented Mar 20, 2023

@MichaIng You'll have to update the containers from v1.23 to v1.26 in .github/workflows/build.yml:

Screenshot from 2023-03-20 19-49-48

Signed-off-by: MichaIng <micha@dietpi.com>
@MichaIng
Copy link
Contributor Author

MichaIng commented Mar 20, 2023

Ah, make sense.

Now I see those %ssudo and %sstart. Feels like the very same as on our docs and website repos: Spell checking is generally great, but one has to maintain a huge exclusion/word list 😄. I was not brave enough to implement it in DietPi main repo, yet 🙈. EDIT: Although codespell seems to do a very good job in code OOTB, better than aspell on filtered HTML.

@DL6ER
Copy link
Member

DL6ER commented Mar 20, 2023

Should be fixed in development but but I'm happy to overwrite code-spell here. Thanks for your PR!

@DL6ER DL6ER merged commit d35edd4 into pi-hole:development Mar 20, 2023
@MichaIng MichaIng deleted the development branch March 20, 2023 19:59
@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/pi-hole-ftl-v5-22-web-v5-19-and-core-v5-16-1-released/61999/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants