Remove code duplication found in gravit.sh gravity_ParseFileIntoDomains() #1566
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR aim to accomplish?:
With the transition of
parseList()
fromgravity.sh
to FTL realm some code duplication occurred. Duplicated code is fromgravity_ParseFileIntoDomains()
https://github.com/pi-hole/pi-hole/blob/50d67dce73e122d98026ab2a4b30255efd9b05fc/gravity.sh#L639-L667
No all input modifications were duplicated into FTL so we could not remove
gravity_ParseFileIntoDomains
completely.How does this PR accomplish the above?:
Removes the duplicates
P.S. It would also be possible to move the whole
gravity_ParseFileIntoDomains
also into FTL's realm, however this would require more modifications (incore
andFTL
By submitting this pull request, I confirm the following:
git rebase
)