Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable FTL's DB functionality on errors #166

Merged
merged 2 commits into from
Dec 7, 2017

Conversation

DL6ER
Copy link
Member

@DL6ER DL6ER commented Nov 29, 2017

By submitting this pull request, I confirm the following (please check boxes, eg [X]) Failure to fill the template will close your PR:

Please submit all pull requests against the development branch. Failure to do so will delay or deny your request

  • I have read and understood the contributors guide.
  • I have checked that another pull request for this purpose does not exist.
  • I have considered, and confirmed that this submission will be valuable to others.
  • I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • I give this submission freely, and claim no ownership to its content.

How familiar are you with the codebase?:

10


Disable FTL's database functionality on all errors except SQLITE_BUSY. I'm not sure if other errors should be (temporarily) allowed as well, but I don't think so.

"Error codes" are a subset of "result codes" that indicate that something has gone wrong. There are only a few non-error result codes: SQLITE_OK, SQLITE_ROW, and SQLITE_DONE. The term "error code" means any result code other than these three.

This template was created based on the work of udemy-dl.

…they should not lead to disabling of the database

Signed-off-by: DL6ER <dl6er@dl6er.de>
@DL6ER DL6ER added this to the v2.13 milestone Nov 29, 2017
@DL6ER DL6ER requested a review from a team November 29, 2017 23:25
@DL6ER DL6ER merged commit e3a63d3 into development Dec 7, 2017
@DL6ER DL6ER deleted the tweak/disable_db_on_unknown_error branch December 7, 2017 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants