Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for "(no branch)" output #177

Merged
merged 2 commits into from
Dec 23, 2017
Merged

Fix for "(no branch)" output #177

merged 2 commits into from
Dec 23, 2017

Conversation

DL6ER
Copy link
Member

@DL6ER DL6ER commented Dec 23, 2017

By submitting this pull request, I confirm the following (please check boxes, eg [X]) Failure to fill the template will close your PR:

Please submit all pull requests against the development branch. Failure to do so will delay or deny your request

  • I have read and understood the contributors guide.
  • I have checked that another pull request for this purpose does not exist.
  • I have considered, and confirmed that this submission will be valuable to others.
  • I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • I give this submission freely, and claim no ownership to its content.

How familiar are you with the codebase?:

10


Travis CI pulls on a tag basis, not by branch. Fix the returned branch if we find that the binary was build on "(no branch)" but is properly tagged.

This template was created based on the work of udemy-dl.

…h if we find that the binary was build on "(no branch)" but is properly tagged.

Signed-off-by: DL6ER <dl6er@dl6er.de>
@DL6ER DL6ER added the Bugfix label Dec 23, 2017
@DL6ER DL6ER requested a review from a team December 23, 2017 11:03
Signed-off-by: DL6ER <dl6er@dl6er.de>
@DL6ER DL6ER modified the milestones: v3.0, v2.14 Dec 23, 2017
@AzureMarker AzureMarker merged commit 2984ae4 into development Dec 23, 2017
@AzureMarker AzureMarker deleted the fix/no_branch branch December 23, 2017 16:25
@AzureMarker AzureMarker modified the milestones: v2.14, v2.13.2 Jan 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants