Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Amend the help text of the TLS certificate #2098

Merged
merged 4 commits into from
Oct 27, 2024
Merged

Conversation

yubiuser
Copy link
Member

What does this PR aim to accomplish?:

Improve the help text of the webserver.tls.cert config.

Fixes https://discourse.pi-hole.net/t/v6-self-signed-certificate-issues/73640


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code and I have tested my changes.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)
  6. I have checked that another pull request for this purpose does not exist.
  7. I have considered, and confirmed that this submission will be valuable to others.
  8. I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  9. I give this submission freely, and claim no ownership to its content.

  • I have read the above and my PR is ready for review. Check this box to confirm

Signed-off-by: yubiuser <github@yubiuser.dev>
@yubiuser yubiuser requested a review from DL6ER October 26, 2024 07:20
@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/v6-self-signed-certificate-issues/73640/9

Copy link
Member

@DL6ER DL6ER left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll also need to edit the test/pihole.toml file as the tests expect the file to be created correctly

src/config/config.c Outdated Show resolved Hide resolved
yubiuser and others added 2 commits October 26, 2024 09:34
Co-authored-by: Dominik <DL6ER@users.noreply.github.com>
Signed-off-by: yubiuser <ckoenig@posteo.de>
Signed-off-by: yubiuser <github@yubiuser.dev>
@yubiuser
Copy link
Member Author

You'll also need to edit the test/pihole.toml file as the tests expect the file to be created correctly

I feared so.

test/pihole.toml Outdated Show resolved Hide resolved
@DL6ER DL6ER changed the title Amend the help text of the tls certificate Amend the help text of the TLS certificate Oct 26, 2024
Co-authored-by: Dominik <DL6ER@users.noreply.github.com>
Signed-off-by: yubiuser <ckoenig@posteo.de>
@DL6ER DL6ER enabled auto-merge October 27, 2024 07:17
@DL6ER DL6ER merged commit 3dd756d into development Oct 27, 2024
19 checks passed
@DL6ER DL6ER deleted the tweak/cert_help branch October 27, 2024 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants