Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not redirect to login page for ACME challenges #2207

Merged
merged 2 commits into from
Feb 19, 2025

Conversation

DL6ER
Copy link
Member

@DL6ER DL6ER commented Feb 19, 2025

What does this implement/fix?

See title and #2202 for details.


Related issue or feature (if applicable): Fixes #2202

Pull request in docs with documentation (if applicable): N/A


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)

Checklist:

  • The code change is tested and works locally.
  • I based my code and PRs against the repositories developmental branch.
  • I signed off all commits. Pi-hole enforces the DCO for all contributions
  • I signed all my commits. Pi-hole requires signatures to verify authorship
  • I have read the above and my PR is ready for review.

Signed-off-by: DL6ER <dl6er@dl6er.de>
@DL6ER DL6ER requested a review from a team February 19, 2025 17:18
@firefart
Copy link

firefart commented Feb 19, 2025

Still getting redirected according to webserver.log:

[2025-02-19 19:59:39.621 CET 7325] Authentication required, redirecting to /admin/login
[2025-02-19 19:59:39.661 CET 7325] Authentication required, redirecting to /admin/login

I think the problem is because of the strcmp, you check for an equal string, but it should only start with the path. The file within the acme-challenge directory has a random name, for example /.well-known/acme-challenge/FZSXUfuC6geuL8prbg9bJFyZjedTGwy4 or /.well-known/acme-challenge/s5j6NbOiX0Uv05DDQunjRHPjjIiWdZLl

@DL6ER
Copy link
Member Author

DL6ER commented Feb 19, 2025

Yes, I didn't know that there will be files in this directory. I just pushed a corresponding change.

Signed-off-by: DL6ER <dl6er@dl6er.de>
@DL6ER DL6ER force-pushed the tweak/acme-challenge branch from c2cf755 to 15cede0 Compare February 19, 2025 19:47
@firefart
Copy link

Thanks! Works now as expected

@DL6ER DL6ER merged commit 84096f4 into development Feb 19, 2025
19 checks passed
@DL6ER DL6ER deleted the tweak/acme-challenge branch February 19, 2025 20:34
@PromoFaux PromoFaux mentioned this pull request Feb 20, 2025
@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/v6-post-release-fixes-and-findings/76480/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants