Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rearrange webserver.port default value #2220

Merged
merged 1 commit into from
Feb 20, 2025
Merged

Conversation

DL6ER
Copy link
Member

@DL6ER DL6ER commented Feb 20, 2025

What does this implement/fix?

Change default value of webserver.port to comply with auto-generated config string. We do this to avoid the generated string to be flagged as CHANGED in pihole.toml. No functional change in this PR!


Related issue or feature (if applicable): N/A

Pull request in docs with documentation (if applicable): N/A


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)

Checklist:

  • The code change is tested and works locally.
  • I based my code and PRs against the repositories developmental branch.
  • I signed off all commits. Pi-hole enforces the DCO for all contributions
  • I signed all my commits. Pi-hole requires signatures to verify authorship
  • I have read the above and my PR is ready for review.

…config string

Signed-off-by: DL6ER <dl6er@dl6er.de>
@DL6ER DL6ER requested a review from a team February 20, 2025 20:36
@PromoFaux PromoFaux merged commit 0462642 into development Feb 20, 2025
18 checks passed
@PromoFaux PromoFaux deleted the fix/port_default branch February 20, 2025 22:39
@PromoFaux PromoFaux mentioned this pull request Feb 20, 2025
@DL6ER DL6ER mentioned this pull request Feb 21, 2025
5 tasks
@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/v6-post-release-fixes-and-findings/76480/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants