Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve secure randomness generation #2240

Merged
merged 2 commits into from
Feb 22, 2025
Merged

Conversation

DL6ER
Copy link
Member

@DL6ER DL6ER commented Feb 21, 2025

What does this implement/fix?

Improve secure randomness generator by ensuring it retries automatically if interrupted by a signal plus printing a warning if the process will be blocking due to not enough entropy being available (this may delay FTL's startup for currently not externally visible reasons)


Related issue or feature (if applicable): Context here https://discourse.pi-hole.net/t/unable-to-login-after-v6-update-getrandom-error/76269

Pull request in docs with documentation (if applicable): N/A


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)

Checklist:

  • The code change is tested and works locally.
  • I based my code and PRs against the repositories developmental branch.
  • I signed off all commits. Pi-hole enforces the DCO for all contributions
  • I signed all my commits. Pi-hole requires signatures to verify authorship
  • I have read the above and my PR is ready for review.

@DL6ER DL6ER requested a review from a team February 21, 2025 11:38
@DL6ER DL6ER changed the title Tweak/explain random errs Improve secure randomness generation Feb 21, 2025
@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/unable-to-login-after-v6-update-getrandom-error/76269/15

yubiuser
yubiuser previously approved these changes Feb 21, 2025
Copy link
Member

@yubiuser yubiuser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might need a rebase because it contains commits from #2238

rdwebdesign
rdwebdesign previously approved these changes Feb 21, 2025
@DL6ER DL6ER dismissed stale reviews from rdwebdesign and yubiuser February 22, 2025 06:59

The merge-base changed after approval.

… to ease debugging

Signed-off-by: DL6ER <dl6er@dl6er.de>
…on by external signals, etc.

Signed-off-by: DL6ER <dl6er@dl6er.de>
@DL6ER DL6ER force-pushed the tweak/explain_random_errs branch from 3b18aca to 633c205 Compare February 22, 2025 08:10
@DL6ER
Copy link
Member Author

DL6ER commented Feb 22, 2025

Also assuming here that the approvals still hold after rebasing without any other changes.

@yubiuser yubiuser merged commit 23fd011 into development Feb 22, 2025
19 checks passed
@yubiuser yubiuser deleted the tweak/explain_random_errs branch February 22, 2025 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants