Remove memory sub-structure #317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: DL6ER <dl6er@dl6er.de>
AzureMarker
approved these changes
Jun 24, 2018
AzureMarker
added a commit
to pi-hole/docs
that referenced
this pull request
Jan 26, 2019
These commands have been removed from FTL: pi-hole/FTL#395 pi-hole/FTL#317
AzureMarker
added a commit
to pi-hole/docs
that referenced
this pull request
Jan 26, 2019
These commands have been removed from FTL: pi-hole/FTL#395 pi-hole/FTL#317 Signed-off-by: Mark Drobnak <mark.drobnak@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm the following (please check boxes, eg [X]) Failure to fill the template will close your PR:
Please submit all pull requests against the
developmentbranch. Failure to do so will delay or deny your requestHow familiar are you with the codebase?:
10
This PR removes the
memorysub-structure. It has been there since the very early days of FTL and was only meant for debugging reasons. As we have never used it (and cannot account for the memory used by the DNS resolver), it should be removed as more and more features make it less and lessaccurate (read as: wrong).
This PR has no negative effects besides removal of the telnet endpoint
>memorywhich is, however, also not exposed through the API so only a few (or no) users should be aware of it.This template was created based on the work of
udemy-dl.