Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new query type QUERY_EXTERNAL_BLOCKED #353

Merged
merged 1 commit into from
Aug 17, 2018

Conversation

DL6ER
Copy link
Member

@DL6ER DL6ER commented Aug 15, 2018

By submitting this pull request, I confirm the following (please check boxes, eg [X]) Failure to fill the template will close your PR:

Please submit all pull requests against the development branch. Failure to do so will delay or deny your request

  • I have read and understood the contributors guide.
  • I have checked that another pull request for this purpose does not exist.
  • I have considered, and confirmed that this submission will be valuable to others.
  • I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • I give this submission freely, and claim no ownership to its content.

How familiar are you with the codebase?:

10


Add new query type QUERY_EXTERNAL_BLOCKED triggered by an NXDOMAIN response with set AD bit. This is how Quad9 signals a blocked domain as suggested here (this behavior has been confirmed in private communication).

The web interface needs to be adapted to acknowledge this new query type in a follow-up PR on the AdminLTE repo.

This template was created based on the work of udemy-dl.

…sponse with set AD bit (this is how Quad9 signals a blocked domain)

Signed-off-by: DL6ER <dl6er@dl6er.de>
@DL6ER DL6ER added this to the v4.1 milestone Aug 15, 2018
@DL6ER DL6ER requested a review from a team August 15, 2018 21:50
@AzureMarker
Copy link
Contributor

Is this a standard practice, or only implemented by Quad9?

@DL6ER
Copy link
Member Author

DL6ER commented Aug 16, 2018

I'm not aware of any other freely available DNS provider that does itself blocking where I could test this.

@DL6ER DL6ER merged commit 51234de into development Aug 17, 2018
@DL6ER DL6ER deleted the new/quad9_nxdomain_adbit branch August 17, 2018 16:19
@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/seeing-upstream-null-results-non-changeable/12539/2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants