Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PRIVACY_NOSTATS mode that skips all analysis #357

Merged
merged 1 commit into from
Aug 19, 2018

Conversation

DL6ER
Copy link
Member

@DL6ER DL6ER commented Aug 19, 2018

By submitting this pull request, I confirm the following (please check boxes, eg [X]) Failure to fill the template will close your PR:

Please submit all pull requests against the development branch. Failure to do so will delay or deny your request

  • I have read and understood the contributors guide.
  • I have checked that another pull request for this purpose does not exist.
  • I have considered, and confirmed that this submission will be valuable to others.
  • I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • I give this submission freely, and claim no ownership to its content.

How familiar are you with the codebase?:

10


Add PRIVACY_NOSTATS mode that skips all (!) analysis. We furthermore don't even try to import or save anything to the database.

This will not only be helpful for those asking for even increased privacy over what we already offer (counters and overtime statistics with fully anonymized query data) but also for those running huge Pi-hole deploys where the initial reading in of the historic data (with up to millions of queries) causes a massive startup delay of several minutes (see, e.g., pi-hole/pi-hole#2374).

…don't even try to import or save anything to the database.

Signed-off-by: DL6ER <dl6er@dl6er.de>
@DL6ER DL6ER added this to the v4.1 milestone Aug 19, 2018
@DL6ER DL6ER requested a review from a team August 19, 2018 12:21
@DL6ER DL6ER changed the title Add PRIVACY_NOSTATS mode that skips all (!) analysis. Add PRIVACY_NOSTATS mode that skips all analysis Aug 19, 2018
@AzureMarker
Copy link
Contributor

When adding the corresponding documentation, it should be pointed out that users will have to disable logging as well (pihole logging off) so the dnsmasq log gets disabled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants