Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure proper file ownerships if pihole-FTL is started as root #366

Merged
merged 2 commits into from
Aug 29, 2018

Conversation

DL6ER
Copy link
Member

@DL6ER DL6ER commented Aug 27, 2018

By submitting this pull request, I confirm the following (please check boxes, eg [X]) Failure to fill the template will close your PR:

Please submit all pull requests against the development branch. Failure to do so will delay or deny your request

  • I have read and understood the contributors guide.
  • I have checked that another pull request for this purpose does not exist.
  • I have considered, and confirmed that this submission will be valuable to others.
  • I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • I give this submission freely, and claim no ownership to its content.

How familiar are you with the codebase?:

10


When started as root, e.g., because capabilities are not available on the current system, we drop from root to some unprivileged user as soon as we did everything we needed to do as root (open privileged ports, etc.).

Unfortunately, the log and database files were still owned by root in this case and hence no further logging was possible, neither to the database nor to the pihole-FTL.log file.

This PR fixes a bug discussed on Discourse.

This template was created based on the work of udemy-dl.

…op back from root to user pihole:pihole as soon as we did everything we needed to do as root (open privileged ports, etc.).

Signed-off-by: DL6ER <dl6er@dl6er.de>
@DL6ER DL6ER added this to the v4.1 milestone Aug 27, 2018
@DL6ER DL6ER requested a review from a team August 27, 2018 15:06
Signed-off-by: DL6ER <dl6er@dl6er.de>
@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/ftldns-upgrade-failed-solved/12022/48

@AzureMarker
Copy link
Contributor

This PR requires pi-hole/pi-hole#2394

@AzureMarker AzureMarker merged commit 42997d5 into development Aug 29, 2018
@AzureMarker AzureMarker deleted the fix/file_permissions_as_root branch August 29, 2018 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants