Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply patch: Fix crash parsing a --synth-domain with no prefix. #369

Merged
merged 1 commit into from
Aug 31, 2018

Conversation

DL6ER
Copy link
Member

@DL6ER DL6ER commented Aug 31, 2018

By submitting this pull request, I confirm the following (please check boxes, eg [X]) Failure to fill the template will close your PR:

Please submit all pull requests against the development branch. Failure to do so will delay or deny your request

  • I have read and understood the contributors guide.
  • I have checked that another pull request for this purpose does not exist.
  • I have considered, and confirmed that this submission will be valuable to others.
  • I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • I give this submission freely, and claim no ownership to its content.

How familiar are you with the codebase?:

10


Apply a patch streamlined for dnsmasq v2.80.

This problem was introduced in 2.79. This fixes #367.

This patch would also be part of dnsmasq v2.80, however, it is unclear if 2.80 will be stable before we release Pi-hole v4.1. It won't be an issue to upgrade the internal dnsmasq code to 2.80 later as we do the update by applying a series of patches where this patch will then simply be skipped with "nothing to do".

This template was created based on the work of udemy-dl.

Problem introduced in 2.79/6b2b564ac34cb3c862f168e6b1457f9f0b9ca69c

This fixes #367

Signed-off-by: DL6ER <dl6er@dl6er.de>
@DL6ER DL6ER added the Bugfix label Aug 31, 2018
@DL6ER DL6ER added this to the v4.1 milestone Aug 31, 2018
@DL6ER DL6ER requested a review from a team August 31, 2018 10:35
@DL6ER DL6ER mentioned this pull request Aug 31, 2018
3 tasks
@AzureMarker AzureMarker merged commit 0e04d64 into development Aug 31, 2018
@AzureMarker AzureMarker deleted the fix/synth-domain branch August 31, 2018 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants