Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve externally blocked detection #372

Merged
merged 3 commits into from
Sep 2, 2018

Conversation

DL6ER
Copy link
Member

@DL6ER DL6ER commented Sep 2, 2018

By submitting this pull request, I confirm the following (please check boxes, eg [X]) Failure to fill the template will close your PR:

Please submit all pull requests against the development branch. Failure to do so will delay or deny your request

  • I have read and understood the contributors guide.
  • I have checked that another pull request for this purpose does not exist.
  • I have considered, and confirmed that this submission will be valuable to others.
  • I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • I give this submission freely, and claim no ownership to its content.

How familiar are you with the codebase?:

10


This PR implements two new things:

  • Also compare the IPs of queries replied to from cache against the known upstream blacklist IPs. We previously missed these ans displayed them in green as OK (cached) as they are - at first sight - perfectly valid IP addresses in our cache.
  • Detect upstream returned NULL address as externally blocked query (Discourse Feature Request)

Test of the two point above:

$ dig c.cx +short
0.0.0.0
$ dig c.cx +short
0.0.0.0

The first query is forwarded to my local unbound (1.8ms) whereas the second is replied to from pi-hole-FTL's cache (1.1ms):
screenshot at 2018-09-02 10-17-44

This template was created based on the work of udemy-dl.

@DL6ER DL6ER added this to the v4.1 milestone Sep 2, 2018
@DL6ER DL6ER requested a review from a team September 2, 2018 08:35
@DL6ER DL6ER changed the title Fix for externally blocked detection Improve externally blocked detection Sep 2, 2018
@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/seeing-upstream-null-results-non-changeable/12539/5

@AzureMarker
Copy link
Contributor

Also compare the IPs of queries replied to from cache against the known upstream blacklist IPs. We previously missed these ans displayed them in green as OK (cached) as they are - at first sight - perfectly valid IP addresses in our cache.

Are these changes in this PR?

@DL6ER
Copy link
Member Author

DL6ER commented Sep 2, 2018

Are these changes in this PR?

My bad, I forgot to git push

Signed-off-by: DL6ER <dl6er@dl6er.de>
@DL6ER DL6ER merged commit 8d34229 into development Sep 2, 2018
@DL6ER DL6ER deleted the new/detect_NULL_reply_as_ext_blocked branch September 2, 2018 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants