Log to stdout when in no-daemon mode #430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
no-daemon mode operates just like debug mode, but without the debug output, and dnsmasq is not in debug mode. Signed-off-by: Mcat12 <newtoncat12@yahoo.com>
|
I don't understand the logic of this PR. It doesn't seem to change the behavior of |
|
I may have messed up my explanation. I was testing with dnsmasq in debug mode, and then before committing decided to change it to not put dnsmasq in debug mode. Currently, the changes mostly just make better use of the |
DL6ER
approved these changes
Dec 12, 2018
DL6ER
changed the title
DL6ER
added a commit
that referenced
this pull request
Dec 14, 2018
Fix no-daemon mode forking dnsmasq and not logging
DL6ER
added a commit
that referenced
this pull request
Dec 14, 2018
Fix no-daemon mode forking dnsmasq and not logging Signed-off-by: DL6ER <dl6er@dl6er.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm the following:
How familiar are you with the codebase?: 10
no-daemon mode operates just like debug mode, but without the debug output, and dnsmasq is not in debug mode.
Note that there is an issue in no-daemon mode where Ctrl-C and other such signals do not stop FTL like in debug mode. However, I could only fix this by putting dnsmasq in debug mode...
This template was created based on the work of
udemy-dl.